Skip to content

⬆️ Webserver node locking: missing change #8230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

⬆️ Webserver node locking: missing change #8230

merged 1 commit into from
Aug 19, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 19, 2025

What do these changes do?

Changes introduced by #8170 did not trigger the api tests in the CI. This fixes the failure in master CI.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Voyager milestone Aug 19, 2025
@sanderegg sanderegg self-assigned this Aug 19, 2025
@sanderegg sanderegg added the a:api framework api, data schemas, label Aug 19, 2025
@sanderegg sanderegg merged commit 1ff6eb2 into ITISFoundation:master Aug 19, 2025
3 of 4 checks passed
@sanderegg sanderegg deleted the additional/node-locking-missing-change branch August 19, 2025 06:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Aug 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.86%. Comparing base (b85b814) to head (8aa4ff0).
⚠️ Report is 27 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b85b814) and HEAD (8aa4ff0). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (b85b814) HEAD (8aa4ff0)
unittests 32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8230       +/-   ##
===========================================
- Coverage   88.06%   66.86%   -21.20%     
===========================================
  Files        1915      758     -1157     
  Lines       73880    35282    -38598     
  Branches     1300      175     -1125     
===========================================
- Hits        65061    23593    -41468     
- Misses       8428    11632     +3204     
+ Partials      391       57      -334
Flag Coverage Δ *Carryforward flag
integrationtests 64.09% <ø> (ø) Carriedforward from b85b814
unittests 76.14% <ø> (-10.56%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.84% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 76.14% <ø> (ø)
director_v2 78.09% <ø> (-12.89%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.13% <ø> (-2.92%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.89% <ø> (-29.27%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85b814...8aa4ff0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 8aa4ff0.

❌ Failed Jobs

Pipeline Job Health on base branch Retries 🔍 CI Insights 📄 Logs
CI system-tests Broken 0 View View

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

Assignees

@sanderegg sanderegg

Labels

a:api framework api, data schemas, t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

1 participant

@sanderegg